WIP: Fix HelpFormatter.write_usage producing spurious characters#3434
Merged
Rowlando13 merged 1 commit intoMay 16, 2026
Merged
Conversation
Collaborator
Author
|
This PR is ready to be reviewed and merged upstream. |
kdeldycke
force-pushed
the
fix-3360-write-usage-empty-args
branch
from
9d43f96 to
0551bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans-up the way the usage line is produce in the help by stripping all spurious trailing spaces produced by various parameters and indention setup. Also normalizes the second whitespace-only line that is used as separator for that section of the help screen.
Closes #3360.
The other related bug #1550 I mentioned in #3360 (comment) has been fixed in an unrelated commit a while ago. But use the opportunity to cover that case in the new test suite.