shell autocomplete uses normalize_choice() #3471
Merged
Merged
Conversation
a831c49 to
105a044
Compare
-fixes enum choice autocomplete showing "MyEnum.foo" instead of "foo" -changed shell_complete() to use normalize_choice() instead of simply converting choices to strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell completion for
Choicewith enum types doesn't work. When usingChoice(MyEnum), autocomplete suggests"MyEnum.foo"instead of"foo", which is the actual accepted value. (#3015) I've changed shell_complete() to use normalize_choice() instead of simply converting choices to strings like in #3017, this does fail the test_choice_case_sensitive() test though.I can fix the enum autocomplete bug, but there's a decision to make:
A) Manually handle enums, preserve original case
test_choice_case_sensitivepasses as isnormalize_choice()overridesB) Use
normalize_choice()for consistency (current approach)["Au", "al"]to["au", "al"]whencase_sensitive=FalseI can amend the current approach to update the test I've just left a note for now! 😃