Fix tests to not rely on -Wdefault option#3591
Merged
Merged
Conversation
kdeldycke
changed the title
-Wdefault option
oojBuffalo
pushed a commit
to oojBuffalo/scrolls
that referenced
this pull request
Jun 14, 2026
…DR 0084) A saved github.com/<owner>/<repo>/issues/<n> or /pull/<n> URL collapsed to the repo and produced its README scroll, discarding the discussion. Extend the github source to cover issue/PR threads as a second content kind: identity owner/repo#<n> (GitHub's cross-ref notation), the adapter dispatching on the '#' — the huggingface one-source-many-kinds shape, not gist's own-source split, since an issue lives on github.com/api.github.com and extends the repo's id, keeping the repo path byte-unchanged. - detect: /issues/<n> and the web PR path /pull/<n> (all-digit) → owner/repo#<n>; deep thread links dedupe, while /blob, /tree, the /issues,/pulls lists, and /pull/new still collapse to owner/repo. - adapter: the issues endpoint serves both kinds (a PR carries pull_request); one GET fetches the thread, comments a second GET (?per_page=100) only when present, degrading to body-only. Markdown body + bylined comments → extracted_text; labels → concepts (the github-topics rule); kind + state (issue/pull request, open/closed/merged via pull_request.merged_at) → tags; github.com/<owner>/<repo> link → the issue↔repo edge + body-URL scan. - classify: github → project now applies only to repos; a '#'-bearing id is unclassified like HN/Lobsters/Discourse, falling through to title rules (a "how to" issue is still a tutorial). Live keyless-verified: psf/requests#1, pallets/flask#5004 (label cli → concept), and merged PR pallets/click#3591 (tags ['pull request','merged']); end-to-end ingest leaves an unclassified thread scroll with the issue↔repo graph edge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a context manager to explicitly check for the exception message.
This is a non-idiomatic way of checking the behavior that rely on running tests with
-Wdefaultoption. It was introduced by me in #3404 (commit 0f71fe7).Closes #3476.