Conversation
Simplify the `jinja.debug` code. On Python >= 3.7, `tb_next` is directly assignable. On PyPy, use transparent proxies only if support is enabled. For cpython < 3.7, use ctypes to set `tb_next`. Rewrite the ctypes code to use `py_object` and `pythonapi.Py_IncRef`, which seems to avoid crashing on debug builds. On Python 3, a rewritten `TemplateSyntaxError` would retain the frames from the compiler functions for some reason. Clear these so the template source is the last thing in the traceback.
Member
Author
|
It seems that PyPy 2 and 3 don't clear the exception's original traceback, so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the
jinja.debugcode.On Python >= 3.7,
tb_nextis directly assignable. On PyPy, use transparent proxies only if support is enabled. For cpython < 3.7, use ctypes to settb_next. Rewrite the ctypes code to usepy_objectandpythonapi.Py_IncRef, which seems to avoid crashing on debug builds. Fixes #1104On Python 3, a rewritten
TemplateSyntaxErrorwould retain the frames from the compiler functions for some reason. Clear these so the template source is the last thing in the traceback. Fixes #763