Add type annotation for FILTERS dictionary#2135
Closed
Teylersf wants to merge 2 commits intopallets:mainfrom
Closed
Add type annotation for FILTERS dictionary#2135Teylersf wants to merge 2 commits intopallets:mainfrom
Teylersf wants to merge 2 commits intopallets:mainfrom
Conversation
davidism
reviewed
Feb 12, 2026
| @@ -1,4 +1,4 @@ | |||
| """Built-in template filters used with the ``|`` operator.""" | |||
| """Built-in template filters used with the ``|`` operator.""" | |||
Member
There was a problem hiding this comment.
Why did you change this line? What is the change?
Author
|
@davidism Thanks for catching that! That ? was added accidentally — it wasn't intentional. I'll revert that line back to the original docstring. Appreciate the sharp eye during review! |
Author
|
@davidism The stray character has been fixed by pre-commit.ci in commit |
Member
|
What "?" are you referring to. I see that pre-commit reverted something, but it looks exactly the same in both diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit type annotation t.Dict[str, t.Callable[..., t.Any]] to the FILTERS dictionary to improve type checking and IDE support.
Fixes #2120