fix: add type annotation for FILTERS and TESTS dictionaries#2139
Closed
nightcityblade wants to merge 1 commit intopallets:mainfrom
Closed
fix: add type annotation for FILTERS and TESTS dictionaries#2139nightcityblade wants to merge 1 commit intopallets:mainfrom
nightcityblade wants to merge 1 commit intopallets:mainfrom
Conversation
Add explicit type annotations to the module-level `FILTERS` and `TESTS` dictionaries so that type checkers like Pylance/Pyright can properly infer the type of `Environment.filters` and `Environment.tests`. Closes pallets#2120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2120
Summary
Add explicit
dict[str, t.Callable[..., t.Any]]type annotations to the module-levelFILTERSdict infilters.pyandTESTSdict intests.py.This allows type checkers (Pylance/Pyright/mypy) to properly infer the type of
Environment.filtersandEnvironment.tests, which are copied from these module-level dicts.Changes
src/jinja2/filters.py: Add type annotation toFILTERSsrc/jinja2/tests.py: Add type annotation toTESTSTests
mypy: Success, no issues foundruff: All checks passedpytest: 911 passed in 1.32s