Fix include without context in macros#2161
Open
kljnepk wants to merge 7 commits intopallets:stablefrom
Open
Conversation
Handle buffered include without context
Add regression test for macro include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2108
visit_Includecurrently usesyield from template._get_default_module()._body_streamin the sync
without contextbranch unconditionally.That is fine for unbuffered output, but inside buffered frames such as macros it turns
the generated macro into a generator function, so rendering returns the generator repr
instead of the included template output.
This keeps the existing
yield frompath for unbuffered frames and switches bufferedframes to explicit iteration so included output is appended to the frame buffer instead.
Adds a regression test for
{% include "included" without context %}inside a macro.