Add connectivity precheck #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
add_connectivity_check
branch
from
dca85d2 to
0a9ca4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a quick workaround shell script check that will check that the OCP mirrors are available prior to running the action and exit out gracefully. You can always disable this connectivity check with a flag.
Connectivity Check Improvements:
check-connectivity.shscript to verify network access to the OpenShift Mirror before proceeding, with clear error messages on failure (scripts/check-connectivity.sh).action.ymlto run the connectivity check by default, and added a newdisableConnectivityCheckinput to allow users to skip this check if desired (action.yml).README.mdto describe the connectivity requirement, the new automatic check, and how to disable it if necessary (README.md).Shell Script Linting Refactor:
linttarget in theMakefile, and added afix-linttarget for easy formatting fixes (Makefile).make lintfor shell script linting instead of inline commands (.github/workflows/pre-main.yml).