Conversation
Add a free standing `load`/`store` function. Parse the root structure. https://pals-project.readthedocs.io/en/latest/conventions.html#pals-root-object
Member
Author
EZoni
reviewed
Feb 19, 2026
Comment on lines
+21
to
+27
| @model_validator(mode="before") | ||
| @classmethod | ||
| def unpack_json_structure(cls, data): | ||
| """Deserialize the JSON/YAML/...-like dict for facility elements""" | ||
| from pals.kinds.mixin.all_element_mixin import unpack_element_list_structure | ||
|
|
||
| return unpack_element_list_structure(data, "facility", "facility") |
Member
There was a problem hiding this comment.
With the latest updates, I think we have unpack_json_structure defined for
PALSBeamLineLatticeUnionEle
Do you know if all of these classes still need that method? Or can we remove it from some now?
I think a similar question applies to other methods, e.g., from_file and to_file (defined for PALS, BeamLine, Lattice).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a free standing
load/storefunction.Parse the root structure.
https://pals-project.readthedocs.io/en/latest/conventions.html#pals-root-object