Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
+ Coverage 84.12% 84.28% +0.16%
==========================================
Files 47 47
Lines 9465 9539 +74
==========================================
+ Hits 7962 8040 +78
+ Misses 1503 1499 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a predefined field is configured with a nested path (e.g.,
span.name), the nested field should be hidden from regular fields output without triggering the...hidden fields indicator. However, the sibling fields (e.g.,span.context) should not be hidden.Changes:
nested_field_names()method toPredefinedFieldsto iterate over nested predefined field pathsIncludeExcludeKeyFilterfor predefined nested fieldsFormatResultenum to distinguish between formatted, hidden by user (shows...), and hidden by predefined (silent skip)Additional fix for #176