fix(config): change default show mode for time and level fields to 'always'#1264
Merged
fix(config): change default show mode for time and level fields to 'always'#1264
Conversation
…lways' Changes the default 'show' setting from 'auto' to 'always' for both the 'time' and 'level' predefined fields to ensure consistent output format. This prevents the fields from being hidden when certain field variants are absent in the logs, making the output more predictable and uniform. Also adds inline documentation comments explaining the show options.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 67 67
Lines 11567 11567
=======================================
Hits 10170 10170
Misses 1397 1397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
showmode for time and level fields toalwaysSummary
Changes the default
showsetting fromautotoalwaysfor the predefinedtimeandlevelfields in the default configuration.Motivation
The
automode conditionally shows/hides fields based on whether certain field variants are present in the logs. While this can make output more compact, it leads to inconsistent formatting:The
alwaysmode provides consistent, predictable output format regardless of log content.Changes
Configuration Changes
File: etc/defaults/config.toml
Changed for both
timeandlevelpredefined fields:Also added inline documentation explaining the available options:
Behavior Impact
Before (auto mode):
After (always mode):
Examples
Before (show = "auto")
After (show = "always")
Migration
Users who prefer the old behavior can override in user config (
~/.config/hl/config.toml):Breaking Change