Skip to content

fix(pager): handle pager exit and broken pipe gracefully#1330

Merged
pamburus merged 1 commit intomasterfrom
010-pager
Feb 16, 2026
Merged

fix(pager): handle pager exit and broken pipe gracefully#1330
pamburus merged 1 commit intomasterfrom
010-pager

Conversation

@pamburus
Copy link
Copy Markdown
Owner

@pamburus pamburus commented Feb 16, 2026

Fix Pager Exit and Broken Pipe Handling

Summary

Fixes issue where the application would not exit cleanly when the pager closes or when output write operations fail.

Changes

  • Application now exits cleanly when pager is closed (e.g., pressing 'q' in less)
  • Graceful exit on broken pipe when output destination closes early
  • No error messages or hanging processes when pager terminates

Improve pager lifecycle handling to exit cleanly when the pager closes
or when output write fails (broken pipe).
- Application now exits cleanly when pager is closed (e.g., pressing 'q')
- Graceful exit on broken pipe when output destination closes early
- No error messages or hanging processes when pager terminates
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 92.89100% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (4279eb3) to head (6ac0fa2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/pager/src/lib.rs 89.24% 10 Missing ⚠️
src/main.rs 92.10% 3 Missing ⚠️
src/signal_unix.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   88.06%   88.53%   +0.47%     
==========================================
  Files          67       68       +1     
  Lines       11625    11780     +155     
==========================================
+ Hits        10238    10430     +192     
+ Misses       1387     1350      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pamburus pamburus marked this pull request as ready for review February 16, 2026 00:15
@pamburus pamburus merged commit 37c4ebc into master Feb 16, 2026
12 checks passed
@pamburus pamburus deleted the 010-pager branch February 16, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant