refactor(follow): extract merger logic into a testable method#1353
Merged
refactor(follow): extract merger logic into a testable method#1353
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
+ Coverage 89.83% 89.99% +0.16%
==========================================
Files 72 72
Lines 12246 12258 +12
==========================================
+ Hits 11001 11032 +31
+ Misses 1245 1226 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The merger thread in follow mode contained ~60 lines of inline logic that could not be unit-tested without OS-level file watching and threading. It is now a standalone method callable with channels, enabling direct test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1287907 to
cacd126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The merger logic in follow mode was an inline closure spanning ~60 lines inside a thread spawn call, making it impossible to test without OS-level file watching and threading. Extracting it into a method allows direct unit testing via channels, unblocking test coverage for upcoming changes to this code path.