Skip to content

fix: handle JSON object keys containing escape sequences#1386

Merged
pamburus merged 1 commit intomasterfrom
issue/1313
Apr 1, 2026
Merged

fix: handle JSON object keys containing escape sequences#1386
pamburus merged 1 commit intomasterfrom
issue/1313

Conversation

@pamburus
Copy link
Copy Markdown
Owner

@pamburus pamburus commented Apr 1, 2026

Summary

  • Nested object keys containing escape sequences caused a panic during formatting
  • Such keys are now parsed and displayed correctly without performance degradation for the common case

Closes #1313

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 94.91525% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (95db804) to head (b45ce45).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/model.rs 94.91% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files          72       72              
  Lines       12285    12322      +37     
==========================================
+ Hits        11063    11096      +33     
- Misses       1222     1226       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pamburus pamburus marked this pull request as ready for review April 1, 2026 08:03
Nested object keys with escape sequences were causing a panic during formatting. Such keys are now handled correctly without performance degradation for the common case.

Refs: #1313
@pamburus pamburus changed the title fix: handle JSON object keys containing escape sequences (#1313) fix: handle JSON object keys containing escape sequences Apr 1, 2026
@pamburus pamburus enabled auto-merge (squash) April 1, 2026 08:05
@pamburus pamburus merged commit 498ab51 into master Apr 1, 2026
13 checks passed
@pamburus pamburus deleted the issue/1313 branch April 1, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: panicking when parsing a JSON log file

1 participant