feat(cli): support adaptive theme syntax in --theme argument#503
Merged
feat(cli): support adaptive theme syntax in --theme argument#503
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 77.27% 77.43% +0.16%
==========================================
Files 31 31
Lines 4140 4166 +26
==========================================
+ Hits 3199 3226 +27
+ Misses 941 940 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d61647 to
2f27053
Compare
2f27053 to
728c987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--themeargument now supports adaptive theme syntax, allowing different themes for dark and light modes directly from the command line.Changes
Adaptive theme syntax for
--themeThe
--themeflag now accepts two forms:--theme my-theme— uses the same theme regardless of mode--theme "dark:one-dark,light:one-light"— uses different themes depending on the resolved modePreviously, the
--themeflag only accepted a plain theme name and always overrode the config with a fixed theme. Adaptive themes configured inconfig.tomlwere lost when--themewas specified. Now, the CLI argument supports the same expressiveness as the config file.The default value from the config is now shown in
--helpoutput.