Add footer to webpage#443
Conversation
eilmiv
left a comment
There was a problem hiding this comment.
I like the footer, it makes the website look more professional. From what I'm qualified to judge, I agree with the content.
The situation with the two conflicting scroll bars could maybe be resolved by removing the max-height and overflow-y properties from the #scope-sidebar in custom.css. Additionally, I left some very small comments.
| .footer-detail { | ||
| flex: 1; | ||
| width: calc(25% - 2 * 20px);; | ||
| padding: 0px 48px 0px 48px; |
There was a problem hiding this comment.
| @@ -0,0 +1,25 @@ | |||
| <div class="footer"> | |||
There was a problem hiding this comment.
| <div class="footer"> | |
| <footer class="footer"> |
Small nitpick: Could use footer instead of div. This is aligned with the current header and better for accessibility.
|
Thanks for your comments, @eilmiv. I updated the code accordingly. |
@kara-mela just a ping in case you forgot about the scroll bars. (feel free to ignore this comment in case it was an active decision to not address this) |
Motivation A footer give a webpage a visual conclusion. The PaNET webpages currently do not have a footer and we should change that. Modification Added content to footer.html, added designs by creating footer.css and including it in the head of the html document. Result A footer has been added.
|
Thanks for bringing the scroll bars up again. They are annoying me and I already tried to get rid of them but failed. Your solution works! Thanks! Unfortunately, your approvals still don't count. I will ask Paul to inspect this. |

Motivation
A footer give a webpage a visual conclusion. The PaNET webpages currently do not have a footer and we should change that.
Modification
Added content to footer.html, added designs by creating footer.css and including it in the head of the html document.
Result
A footer has been added.
Related Issues
Closes #442