Skip to content

Add footer to webpage#443

Merged
kara-mela merged 1 commit into
pan-ontologies:masterfrom
kara-mela:ISS442-footer
Jun 5, 2026
Merged

Add footer to webpage#443
kara-mela merged 1 commit into
pan-ontologies:masterfrom
kara-mela:ISS442-footer

Conversation

@kara-mela
Copy link
Copy Markdown
Collaborator

Motivation

A footer give a webpage a visual conclusion. The PaNET webpages currently do not have a footer and we should change that.

Modification

Added content to footer.html, added designs by creating footer.css and including it in the head of the html document.

Result

A footer has been added.

Related Issues

Closes #442

Copy link
Copy Markdown
Collaborator

@eilmiv eilmiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the footer, it makes the website look more professional. From what I'm qualified to judge, I agree with the content.

The situation with the two conflicting scroll bars could maybe be resolved by removing the max-height and overflow-y properties from the #scope-sidebar in custom.css. Additionally, I left some very small comments.

Comment thread docs/assets/css/footer.css Outdated
.footer-detail {
flex: 1;
width: calc(25% - 2 * 20px);;
padding: 0px 48px 0px 48px;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding: 0px 48px 0px 48px;
padding: 0px 0px 0px 48px;

My personal preference would be to remove the right padding, e.g. so that the Photon and Neutron Open Science Cluster link no longer has a line break.

To me, it looks like this with 48px right padding:

Image

Comment thread docs/_includes/footer.html Outdated
@@ -0,0 +1,25 @@
<div class="footer">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="footer">
<footer class="footer">

Small nitpick: Could use footer instead of div. This is aligned with the current header and better for accessibility.

@kara-mela
Copy link
Copy Markdown
Collaborator Author

Thanks for your comments, @eilmiv. I updated the code accordingly.

@kara-mela kara-mela requested a review from eilmiv June 4, 2026 13:30
@eilmiv
Copy link
Copy Markdown
Collaborator

eilmiv commented Jun 4, 2026

Thanks for your comments, @eilmiv. I updated the code accordingly.

@kara-mela just a ping in case you forgot about the scroll bars. (feel free to ignore this comment in case it was an active decision to not address this)

Motivation

A footer give a webpage a visual conclusion. The PaNET webpages currently do not have a footer and we should change that.

Modification

Added content to footer.html, added designs by creating footer.css and including it in the head of the html document.

Result

A footer has been added.
@kara-mela
Copy link
Copy Markdown
Collaborator Author

Thanks for bringing the scroll bars up again. They are annoying me and I already tried to get rid of them but failed. Your solution works! Thanks!

Unfortunately, your approvals still don't count. I will ask Paul to inspect this.

@kara-mela kara-mela merged commit b4c5e09 into pan-ontologies:master Jun 5, 2026
3 of 4 checks passed
@kara-mela kara-mela deleted the ISS442-footer branch June 5, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add footer on webpage

2 participants