-
|
I noticed that the annotations for the ExcelWriter class differ from those in the main pandas repository. The latter uses a generic type, which simplifies code writing. Could you please tell me whether the rejection of the generic type is intentional? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 2 replies
-
|
Changes made to the pandas source that are for typing are not always known to us in Having said that, we are open to PR's that align things better. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your reply. I will try to open a PR as soon as possible. |
Beta Was this translation helpful? Give feedback.
-
|
I opened PR #1561. Added a generic for ExcelWriter, as well as an overload for the constructor. |
Beta Was this translation helpful? Give feedback.
Changes made to the pandas source that are for typing are not always known to us in
pandas-stubs. So if someone does a PR forpandasthat improves the typing forpandas(which is intended to help pandas developers), we don't always track those as potential changes to make topandas-stubs(which is intended for pandas users).Having said that, we are open to PR's that align things better.