Index: ensure Index(DatetimeIndex) returns DatetimeIndex (fixes #1440)

[yusufcank34]

• Closes Index(DatetimeIndex) erroneously gives Index[Timestamp] #1440
• Tests added: Please use assert_type() to assert the type of any return value.

[loicdiridollou]

Hey @yusufcank34 ! Thanks for your contribution, could you add some tests to make sure your behavior is working, feel free to look into https://github.com/pandas-dev/pandas-stubs/blob/main/tests/indexes/test_datetime_index.py for examples on how to write a test (especially the check assert type structure).
Let me know if you have questions!

[yusufcank34]

Hey @yusufcank34 ! Thanks for your contribution, could you add some tests to make sure your behavior is working, feel free to look into https://github.com/pandas-dev/pandas-stubs/blob/main/tests/indexes/test_datetime_index.py for examples on how to write a test (especially the check assert type structure). Let me know if you have questions!

added the new test

[loicdiridollou]

Feel free to run poetry run poe test_all locally before you push as it mirrors the CI pipeline.

[loicdiridollou]

Since there is already a test file for datetime index it is probably cleaner to consolidate your tests there (if we made one test file by issue it would quickly become overwhelming).
Another point is that you’d need to add check(assert_type(…), pd.DatetimeIndex) in top of the assertion you have already added here.

[loicdiridollou]

@yusufcank34 Can you remove that file since it is already covered by the other test you modified? And run pre-commit before you push again, I will merge after it.

[loicdiridollou]

Thanks @yusufcank34, nice job on your first PR!

[loicdiridollou]

@yusufcank34 Can you remove that file since it is already covered by the other test you modified? And run pre-commit before you push again, I will merge after it.

[loicdiridollou]

Thanks @yusufcank34 !

[yusufcank34]

Thanks @yusufcank34 !

thk u