Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Oct 30, 2025

The only untyped method here is get_indexer, which can just inherit from the parent definition, there's nothing interval-index-specific about it

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@MarcoGorelli MarcoGorelli marked this pull request as ready for review October 30, 2025 10:28
Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pyproject.toml, could you replace

"*index*" = [
  # TODO: remove when indexes are fully typed
  "ANN001", "ANN201", "ANN204", "ANN206",
]

with

"indexers.pyi" = [
  # TODO: remove when indexers.pyi is fully typed
  "ANN001", "ANN201", "ANN204", "ANN206",
]
"multi.pyi" = [
  # TODO: remove when multi.pyi is fully typed
  "ANN001", "ANN201", "ANN204", "ANN206",
]
"indexing.pyi" = [
  # TODO: remove when indexing.pyi is fully typed
  "ANN001", "ANN201", "ANN204", "ANN206",
]

?

Copy link
Contributor

@cmp0xff cmp0xff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarcoGorelli !

@cmp0xff cmp0xff merged commit 1f5d9d7 into pandas-dev:main Oct 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants