GH1447 Example #1471
Draft
GH1447 Example #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
commented
Nov 6, 2025
| # ignore needed for mypy as we want different results based on the arguments | ||
| @overload # type: ignore[override] | ||
| @overload | ||
| @override |
Member
Author
There was a problem hiding this comment.
@Dr-Irv here is the example with @override, not sure I am using it the right way since it is failing any pipeline.
Dr-Irv
reviewed
Nov 6, 2025
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
Let's kill this idea. I read the specs on override. It's not meant to tell the type checker that an override with different types is OK. It is just meant to tell the type checker that a subclass overriding a method is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing_extensions.override#1447assert_type()to assert the type of any return value