MAINT: #1503 deduplicate tests/__init__.py
#1508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
commented
Nov 27, 2025
Comment on lines
-442
to
-446
| np_1darray_bool: TypeAlias = np.ndarray[tuple[int], np.bool_] | ||
| np_1darray_str: TypeAlias = np.ndarray[tuple[int], np.str_] | ||
| np_1darray_bytes: TypeAlias = np.ndarray[tuple[int], np.bytes_] | ||
| np_1darray_complex: TypeAlias = np.ndarray[tuple[int], np.complexfloating] | ||
| np_1darray_object: TypeAlias = np.ndarray[tuple[int], np.object_] |
Contributor
Author
There was a problem hiding this comment.
These have been incorrect. Should have been np.ndarray[tuple[int], np.dtype[np.bool_]], etc.
cmp0xff
commented
Nov 27, 2025
Comment on lines
2031
to
2049
| def test_types_to_numpy() -> None: | ||
| s = pd.Series(["a", "b", "c"], dtype=str) | ||
| check(assert_type(s.to_numpy(), np_1darray_str), np_1darray_str) | ||
| check(assert_type(s.to_numpy(), np_1darray_object), np_1darray_object) | ||
| check( # <U1, not str_ | ||
| assert_type(s.to_numpy(dtype="str", copy=True), np_1darray), np_1darray | ||
| ) | ||
| check(assert_type(s.to_numpy(na_value=0), np_1darray_object), np_1darray_object) | ||
| check( | ||
| assert_type(s.to_numpy(dtype="str", copy=True), np_1darray_str), np_1darray_str | ||
| assert_type(s.to_numpy(na_value=np.int32(4)), np_1darray_object), | ||
| np_1darray_object, | ||
| ) | ||
| check(assert_type(s.to_numpy(na_value=0), np_1darray_str), np_1darray_str) | ||
| check(assert_type(s.to_numpy(na_value=np.int32(4)), np_1darray_str), np_1darray_str) | ||
| check( | ||
| assert_type(s.to_numpy(na_value=np.float16(4)), np_1darray_str), np_1darray_str | ||
| assert_type(s.to_numpy(na_value=np.float16(4)), np_1darray_object), | ||
| np_1darray_object, | ||
| ) | ||
| check( | ||
| assert_type(s.to_numpy(na_value=np.complex128(4, 7)), np_1darray_str), | ||
| np_1darray_str, | ||
| assert_type(s.to_numpy(na_value=np.complex128(4, 7)), np_1darray_object), | ||
| np_1darray_object, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Behavioural changes
| """Test Series.to_numpy for different types.""" | ||
| s_str = pd.Series(["a", "b", "c"], dtype=str) | ||
| check(assert_type(s_str.to_numpy(), np_1darray_str), np_1darray_str) | ||
| check(assert_type(s_str.to_numpy(), np_1darray_object), np_1darray_object) |
Comment on lines
+1008
to
+1013
| # |S20, not bytes_ | ||
| check(assert_type(o_s.to_numpy(dtype=np.bytes_), np_1darray), np_1darray) | ||
| # |S6, not bytes_ | ||
| check(assert_type(i_s.to_numpy(dtype=np.bytes_), np_1darray), np_1darray) | ||
| # <U6, not str_ | ||
| check(assert_type(i_s.to_numpy(dtype=np.str_), np_1darray), np_1darray) |
Contributor
Author
There was a problem hiding this comment.
Behavioural changes
Comment on lines
+1072
to
+1073
| # |S6, not bytes_ | ||
| check(assert_type(i_i.to_numpy(dtype="bytes", copy=True), np_1darray), np_1darray) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_typing.pyiandtests/__init__.py#1503