-
-
Notifications
You must be signed in to change notification settings - Fork 157
TYP: GroupBy and native types
#1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/test_resampler.py
Outdated
|
|
||
| def test_getattr() -> None: | ||
| check(assert_type(DF.resample("ME").col1, SeriesGroupBy), SeriesGroupBy) | ||
| check(assert_type(DF.resample("ME").col1, "SeriesGroupBy[Any, Any]"), SeriesGroupBy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove [Any, Any] here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/test_resampler.py
Outdated
| assert_type(DF.resample("ME")["col1"], "SeriesGroupBy[Any, Any]"), SeriesGroupBy | ||
| ) | ||
| check( | ||
| assert_type(DF.resample("ME")[["col1", "col2"]], "DataFrameGroupBy[Any, Any]"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove [Any, Any] here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cmp0xff
Towards #1544
GroupByand native types do not have default values in their type variables. AddingAny.