gh-514 Added ExtensionDtype for is_*_dtype functions
#517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Jan 22, 2023
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
For each of the commented out lines, can you add at the end the reference to the pandas Github issue, e.g.:
# check(assert_type(api.is_object_dtype(ExtensionDtype), bool), bool) pandas GH 50923
Contributor
Author
added the reference |
Contributor
Author
thanks sir |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
…andas-dev#517) * added ExtensionDtpe in is_*_dtype() methods * commented the error lines * added reference to Pandas issue in commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_*_dtypefunctions don't accept extension dtypes #514assert_type()to assert the type of any return value