BUG: Reindex with columns and method #14993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
tests please |
jreback
added
Bug
Indexing
jreback
reviewed
Dec 26, 2016
| dtype=float) | ||
| expected_def = DataFrame(data=[[np.nan, 11, 12, np.nan, 13, np.nan], | ||
| [np.nan, 21, 22, np.nan, 23, np.nan], | ||
| [np.nan, 31, 32, np.nan, 33, np.nan]], |
Contributor
There was a problem hiding this comment.
you can just do these as:
result = ....
expected = ...
assert_frame_equal(result, expected)
easier to read this way
jreback
reviewed
Dec 26, 2016
| newFrame = self.frame.reindex(columns=[]) | ||
| self.assertTrue(newFrame.empty) | ||
|
|
||
| # GH 14992, reindexing over columns ignored method |
Contributor
There was a problem hiding this comment.
you can make it a new test
jreback
reviewed
Dec 26, 2016
| [21, 21, 22, 23, 23, np.nan], | ||
| [31, 31, 32, 33, 33, np.nan]], | ||
| index=[1, 2, 4], | ||
| columns=range(6), |
Contributor
There was a problem hiding this comment.
add similar tests for sparse as well.
jreback
reviewed
Dec 26, 2016
doc/source/whatsnew/v0.20.0.txt
Outdated
| - Bug in ``DataFrame(..).apply(to_numeric)`` when values are of type decimal.Decimal. (:issue:`14827`) | ||
| - Bug in ``describe()`` when passing a numpy array which does not contain the median to the ``percentiles`` keyword argument (:issue:`14908`) | ||
| - Bug in ``DataFrame.sort_values()`` when sorting by multiple columns where one column is of type ``int64`` and contains ``NaT`` (:issue:`14922`) | ||
| - Bug in ``DataFrame.reindex()`` when using ``columns`` and ``method`` (:issue:`14992`) |
Contributor
There was a problem hiding this comment.
say that when passingcolumns, method was ignored.
Current coverage is 84.78% (diff: 100%)@@ master #14993 diff @@
==========================================
Files 144 145 +1
Lines 51056 51091 +35
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43225 43316 +91
+ Misses 7831 7775 -56
Partials 0 0
|
Contributor
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff