add missing args, make kwarg explicit

[jbrockmendel]

Index._evaluate_compare is never hit, but if it were it would raise twice: once for not having the right signature and again for referencing a non-existent base.AbstractMethodError

BlockManager.isna is entirely non-obvious because there is a required kwarg that isn't in its signature. This makes it explicit.

[TomAugspurger]

Does line 3962 in https://github.com/pandas-dev/pandas/pull/19691/files#diff-248241e14f081931cc805f9d0e137a5fR3962 not hit Index._evaluate_compare?

[jbrockmendel]

Nope. _evaluate_compare gets overriden in DatetimeIndexOpsMixin, and the only classes that woudl have needs_i8_conversion(self) get it from there.

[codecov]

Codecov Report

Merging #19691 into master will increase coverage by 0.02%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master   #19691      +/-   ##
==========================================
+ Coverage   91.58%    91.6%   +0.02%     
==========================================
  Files         150      150              
  Lines       48867    48867              
==========================================
+ Hits        44755    44767      +12     
+ Misses       4112     4100      -12

Flag	Coverage Δ
#multiple	89.98% <75%> (+0.02%)	⬆️
#single	41.75% <75%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/internals.py	95.05% <100%> (ø)	⬆️
pandas/core/indexes/base.py	96.46% <50%> (ø)	⬆️
pandas/plotting/_converter.py	66.95% <0%> (+1.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d198a6e...e22bf64. Read the comment docs.

[jreback]

thanks!