Skip to content

add missing args, make kwarg explicit #19691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 2 commits into from
Feb 15, 2018
Merged

add missing args, make kwarg explicit #19691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f54a0e
add missing args, make kwarg explicit
jbrockmendel Feb 14, 2018
e22bf64
Merge branch 'master' of https://github.com/pandas-dev/pandas into mi…
jbrockmendel Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3943,8 +3943,8 @@ def _evaluate_with_timedelta_like(self, other, op, opstr, reversed=False):
def _evaluate_with_datetime_like(self, other, op, opstr):
raise TypeError("can only perform ops with datetime like values")

def _evaluate_compare(self, op):
raise base.AbstractMethodError(self)
def _evaluate_compare(self, other, op):
raise com.AbstractMethodError(self)

@classmethod
def _add_comparison_methods(cls):
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3569,8 +3569,8 @@ def reduction(self, f, axis=0, consolidate=True, transposed=False,
placement=np.arange(len(values)))],
axes[0])

def isna(self, **kwargs):
return self.apply('apply', **kwargs)
def isna(self, func, **kwargs):
return self.apply('apply', func=func, **kwargs)

def where(self, **kwargs):
return self.apply('where', **kwargs)
Expand Down