TST: move misplaced modulo test #23827
Conversation
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23827 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51493 51493
=======================================
Hits 47524 47524
Misses 3969 3969
Continue to review full report at Codecov.
|
gfyoung
added
Testing
That seems like a reasonable proposal. |
gfyoung
left a comment
gfyoung
left a comment
There was a problem hiding this comment.
Not sure if we want to do anything else here, but the move LGTM though.
| check_names=False) | ||
|
|
||
| # TODO: this came from tests.series.test_analytics, needs cleannup and | ||
| # de-duplication with test_modulo above |
There was a problem hiding this comment.
Do you want to do that todo here?
There was a problem hiding this comment.
Un-commited changes in my local branch make this a hassle I'd rather avoid.
There was a problem hiding this comment.
yeah let's not increase scope of things, plenty to do already.
jorisvandenbossche
changed the title
|
lgtm. ex @jorisvandenbossche comment (though certainly fine to do this later). |
5 participants
Found this while looking at tests for reduction ops. I'm wondering if we should collect+parametrize those over DataFrame/Series/Index/EA the same way we do for arithmetic. Thoughts?