Skip to content

Fixed PeriodArray._time_shift positional argument #24524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2018
Merged

Fixed PeriodArray._time_shift positional argument #24524

merged 1 commit into from
Dec 31, 2018

Conversation

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Dec 31, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24524 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24524   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <50%> (ø) ⬆️
#single 31.88% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 40.61% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9d41c...61c0dd3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 31, 2018 •
edited
Loading

Codecov Report

Merging #24524 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24524   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <50%> (ø) ⬆️
#single 31.88% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 40.61% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9d41c...61c0dd3. Read the comment docs.

@TomAugspurger TomAugspurger added Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. labels Dec 31, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 31, 2018
@jreback jreback merged commit b49136e into pandas-dev:master Dec 31, 2018
@jreback
Copy link
Contributor

jreback commented Dec 31, 2018

thanks @TomAugspurger

@TomAugspurger TomAugspurger deleted the time_shift_arg branch January 2, 2019 20:18
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
Fixed PeriodArray._time_shift positional argument (pandas-dev#24524)
dbeee7a
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
Fixed PeriodArray._time_shift positional argument (pandas-dev#24524)
a201aa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays.

Projects

None yet

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TomAugspurger @jreback