Skip to content

Conversation

@kaathi524
Copy link
Contributor

@kaathi524 kaathi524 commented Oct 24, 2019

  • closes Clean up noqa E241 #29207
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@WillAyd WillAyd added Clean Code Style Code style, linting, code_checks labels Oct 24, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 24, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 24, 2019

lgtm. cc @TomAugspurger in case he knows any reason why maybe we should keep these, otherwise feel free to merge

By the way @kaathi524 if you are looking to contribute more auditing all of the # noqa comments in our code base might be a good place to start. Especially for any stylistic ones they might just not be applicable any more now that we have black formatting our code base

@TomAugspurger
Copy link
Contributor

Looks good, thanks @kaathi524!

@TomAugspurger TomAugspurger merged commit 34de308 into pandas-dev:master Oct 24, 2019
@kaathi524
Copy link
Contributor Author

@WillAyd Yeah sure.

@WillAyd WillAyd mentioned this pull request Oct 25, 2019
5 tasks
HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up noqa E241

3 participants