Skip to content

Conversation

@WillAyd
Copy link
Member

@WillAyd WillAyd commented Nov 14, 2019

Fixes the following warnings:

pandas/_libs/parsers.c:5873:52: warning: incompatible pointer types assigning to 'double (*)(const char *, char **, char, char, char, int)' from 'double (const char *,
      char **, char, char, char, int, int *, int *)' [-Wincompatible-pointer-types]
    __pyx_v_self->parser->double_converter_withgil = round_trip;
                                                   ^ ~~~~~~~~~~
pandas/_libs/parsers.c:5911:50: warning: incompatible pointer types assigning to 'double (*)(const char *, char **, char, char, char, int)' from 'double (const char *,
      char **, char, char, char, int, int *, int *)' [-Wincompatible-pointer-types]
    __pyx_v_self->parser->double_converter_nogil = precise_xstrtod;
                                                 ^ ~~~~~~~~~~~~~~~
pandas/_libs/parsers.c:5940:50: warning: incompatible pointer types assigning to 'double (*)(const char *, char **, char, char, char, int)' from 'double (const char *,
      char **, char, char, char, int, int *, int *)' [-Wincompatible-pointer-types]
    __pyx_v_self->parser->double_converter_nogil = xstrtod;
                                                 ^ ~~~~~~~
pandas/_libs/parsers.c:23829:93: warning: incompatible function pointer types passing 'double (*)(const char *, char **, char, char, char, int)' to parameter of type
      '__pyx_t_5numpy_float64_t (*)(const char *, char **, char, char, char, int, int *, int *)' (aka 'double (*)(const char *, char **, char, char, char, int, int *, int
      *)') [-Wincompatible-function-pointer-types]
          __pyx_v_error = __pyx_f_6pandas_5_libs_7parsers__try_double_nogil(__pyx_v_parser, __pyx_v_parser->double_converter_nogil, __pyx_v_col, __pyx_v_line_start...
                                                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pandas/_libs/parsers.c:2716:115: note: passing argument to parameter here
static CYTHON_INLINE int __pyx_f_6pandas_5_libs_7parsers__try_double_nogil(parser_t *, __pyx_t_5numpy_float64_t (*)(char const *, char **, char, char, char, int, i...
                                                                                                                  ^
4 warnings generated.

@gfyoung gfyoung added IO Data IO issues that don't fit into a more specific label Internals Related to non-user accessible pandas implementation IO CSV read_csv, to_csv and removed IO Data IO issues that don't fit into a more specific label labels Nov 14, 2019
@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback jreback merged commit 505b6e7 into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks @WillAyd

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@WillAyd WillAyd deleted the token-warnings branch January 16, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internals Related to non-user accessible pandas implementation IO CSV read_csv, to_csv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants