Skip to content

STY: F-strings #29988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2019
Merged

STY: F-strings #29988

merged 4 commits into from
Dec 4, 2019

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Dec 3, 2019 •
edited
Loading

@gfyoung gfyoung added Strings String extension data type and string data Code Style Code style, linting, code_checks labels Dec 3, 2019
@gfyoung
Copy link
Member

gfyoung commented Dec 3, 2019

(Unrelated) Test failure notwithstanding, these changes look good

@jreback jreback added this to the 1.0 milestone Dec 4, 2019
@jreback jreback merged commit 26c9d02 into pandas-dev:master Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the STY-fstrings-1 branch December 4, 2019 15:34
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
F-strings (pandas-dev#29988)
aa97291
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
F-strings (pandas-dev#29988)
0c643c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Code Style Code style, linting, code_checks Strings String extension data type and string data

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @gfyoung @jreback