Skip to content

Conversation

@ShaharNaveh
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these changes - is this purely a stylistic thing you are aiming for?

@ShaharNaveh
Copy link
Contributor Author

Not sure about these changes - is this purely a stylistic thing you are aiming for?

Yes, indeed purely stylistic change, I'll revert.

@jreback jreback added this to the 1.0 milestone Dec 4, 2019
@jreback jreback merged commit c20106f into pandas-dev:master Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-compact-chainmap branch December 4, 2019 15:18
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants