BUG: item_cache invalidation on DataFrame.insert #38380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
jreback
requested changes
Dec 10, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
ok this looks reasonable, pls add a whatsnew note.
OT: is there a meaningful perf drop anywhere else if we make this 1000 or 10000?
…gs-consolidate-2
…gs-consolidate-2
Member
Author
|
whatsnew added + green |
jreback
approved these changes
Dec 11, 2020
Contributor
|
this just puts a warning up |
Member
Author
|
The bug is fixed by removing the _consolidate_inplace, which is replaced with the warning |
jreback
approved these changes
Dec 11, 2020
Contributor
|
ok! |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Dec 11, 2020
* BUG: item_cache invalidation on DataFrame.insert * Whatsnew
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
* BUG: item_cache invalidation on DataFrame.insert * Whatsnew
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffSomething wonky is going on with tm.assert_produces_warning, will see if it shows up on the CI.