Series with dtype=object does unexpected type conversion #39285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ftrihardjo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-28 09:55:31 UTC |
jreback
changed the title
jreback
added
Dtype Conversions
jreback
requested changes
Jan 20, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
pls follow the precommit instructions to lint your code
pandas/tests/series/test_api.py
Outdated
| result = s + 1 | ||
| assert result.attrs == {"version": 1} | ||
|
|
||
| def test_series_with_object_dtype(self): |
Contributor
There was a problem hiding this comment.
these should go in pandas/tests/series/indexing/test_setitem.py
name the test with _empty in its name
pandas/tests/series/test_api.py
Outdated
| series = pd.Series([], dtype=object) | ||
| series["timestamp"] = timestamp | ||
| expected = type(series.timestamp) | ||
| series = pd.Series([], dtype=object) |
pandas/tests/series/test_api.py
Outdated
| timestamp = pd.Timestamp(1412526600000000000) | ||
| series = pd.Series([], dtype=object) | ||
| series["timestamp"] = timestamp | ||
| expected = type(series.timestamp) |
Contributor
There was a problem hiding this comment.
explcity construct the result series and use tm.assert_series_equal
jreback
requested changes
Jan 28, 2021
| series["anything"] = 300.0 | ||
| series["timestamp"] = timestamp | ||
| result = series["timestamp"] | ||
| assert isinstance(result, Timestamp) and isinstance(expected, Timestamp) |
Contributor
There was a problem hiding this comment.
you can
assert result == expected
jreback
approved these changes
Jan 28, 2021
Contributor
|
thanks @ftrihardjo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.