Skip to content

ENH - Improved error message for interpolating IntegerArrays (#41565) #42503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ENH - Improved error message for interpolating IntegerArrays (#41565) #42503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ def clean_fill_method(method, allow_nearest: bool = False):
valid_methods.append("nearest")
expecting = "pad (ffill), backfill (bfill) or nearest"
if method not in valid_methods:
raise ValueError(f"Invalid fill method. Expecting {expecting}. Got {method}")
raise ValueError(
f"Invalid fill method. Expecting {expecting}. Got {method}."
" Are you trying to interpolate an integer column?"
)
Copy link
Member

@mzeitlin11 mzeitlin11 Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error seems like something which might occur more commonly in non-masked cases (from something like a typo) - maybe this is too specific (there are also other nullable types like Float which could end up here)

return method


Expand Down