TYP: mostly missing return annotations in IO #44801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Dec 7, 2021
| def to_clipboard(obj, excel=True, sep=None, **kwargs): # pragma: no cover | ||
| def to_clipboard( | ||
| obj, excel: bool | None = True, sep: str | None = None, **kwargs | ||
| ) -> None: # pragma: no cover |
Member
Author
There was a problem hiding this comment.
is # pragma: no cover for codecov? Does it need to be on the def to_clipboard-line?
|
|
||
|
|
||
| def validate_header_arg(header) -> None: | ||
| def validate_header_arg(header: object) -> None: |
Member
Author
There was a problem hiding this comment.
Typeshed recommends to use Any when it is too difficult to create a type annotations. object should be used if literally any object can be accepted.
https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#conventions
Note that Any is not the correct type to use if you want to indicate that some function can accept literally anything: in those cases use object instead.
pandas/io/html.py
Outdated
| start, step = skiprows.start or 0, skiprows.step or 1 | ||
| return list(range(start, skiprows.stop, step)) | ||
| elif isinstance(skiprows, numbers.Integral) or is_list_like(skiprows): | ||
| assert skiprows is not None |
Member
There was a problem hiding this comment.
can you make this a cast? that way mypy will alert us once it is unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.