BUG: SparseArray.__floordiv__ not matching non-Sparse Series behavior #44928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Dec 16, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Sparse
jreback
requested changes
Dec 17, 2021
pandas/core/arrays/sparse/array.py
Outdated
| # Match the non-Sparse Series behavior | ||
| if name == "floordiv": | ||
| # error: Module has no attribute "sparse_floordiv_float64" | ||
| sparse_op = splib.sparse_floordiv_float64 # type: ignore[attr-defined] |
Contributor
There was a problem hiding this comment.
can you re-assign like
opname = 'sparse_floordiv_float64 ` ? and move L225 below this ?
Member
Author
There was a problem hiding this comment.
good idea, will update
jreback
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.