TST: Add any_string_dtype parameterization to test #44938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
| # https://github.com/pandas-dev/pandas/issues/23558 | ||
| # more than one char | ||
| s = Series(["a__b__c", "c__d__e", np.nan, "f__g__h", None]) | ||
| s = Series(["a__b__c", "c__d__e", np.nan, "f__g__h", None], dtype=any_string_dtype) |
Member
There was a problem hiding this comment.
should this affect expected.dtype?
Member
Author
There was a problem hiding this comment.
Not sure cc @simonjayhawkins
We don't set the expected dtype in the rest of the tests.
Member
There was a problem hiding this comment.
only if we have expand=True (the default) we get a DataFrame with the columns with the same dtype otherwise the result is an object Series of tuples of python strings.
import pandas as pd
print(pd.__version__)
s = pd.Series(["a__b__c", "c__d__e", np.nan, "f__g__h", None], dtype="string[pyarrow]")
print(s)
result1= s.str.partition(sep = "__", expand=False)
print(result1)
result2 = s.str.partition(sep="__", expand=True)
print(result2)
print(result2.dtypes)
print(repr(result2[0].dtype))1.4.0.dev0+1658.g05b85037ab
0 a__b__c
1 c__d__e
2 <NA>
3 f__g__h
4 <NA>
dtype: string
0 (a, __, b__c)
1 (c, __, d__e)
2 <NA>
3 (f, __, g__h)
4 <NA>
dtype: object
0 1 2
0 a __ b__c
1 c __ d__e
2 <NA> <NA> <NA>
3 f __ g__h
4 <NA> <NA> <NA>
0 string
1 string
2 string
dtype: object
string[pyarrow]
Member
|
Thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #44876 (comment)