Skip to content

DOC: Improve pull request template and contributing_codebase.rst #45709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 4 commits into from
Jan 30, 2022
Merged

DOC: Improve pull request template and contributing_codebase.rst #45709

mroeschke merged 4 commits into from
Jan 30, 2022

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 30, 2022

  • Clarified steps & added links
  • Moved some items in code_style.rst to contributing_codebase.rst
  • Removed individual instructions to run black, flake8, etc in favor of pre-commit (since that's how it's run in the CI)

@mroeschke mroeschke added the Docs label Jan 30, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jan 30, 2022
MarcoGorelli
MarcoGorelli approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd been wanting to do this for a while

@mroeschke mroeschke merged commit 237260d into pandas-dev:main Jan 30, 2022
@mroeschke mroeschke deleted the doc/pull_and_testing branch January 30, 2022 17:38
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@mroeschke @phofl
DOC: Improve pull request template and contributing_codebase.rst (pan…
bde1955 
…das-dev#45709)

* DOC: Improve pull request template and contributing guide

* Move some information into contributing

* Fix some typos
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
DOC: Improve pull request template and contributing_codebase.rst (pan…
3f35dce 
…das-dev#45709)

* DOC: Improve pull request template and contributing guide

* Move some information into contributing

* Fix some typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

2 participants

@mroeschke @MarcoGorelli