Skip to content

TST: Allow tm.network to catch urllib.error.URLError #45723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Jan 30, 2022
Merged

TST: Allow tm.network to catch urllib.error.URLError #45723

jreback merged 2 commits into from
Jan 30, 2022

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 30, 2022

Addresses these flaky network errors due to external servers: https://github.com/pandas-dev/pandas/runs/4992270675?check_suite_focus=true

    def http_error_default(self, req, fp, code, msg, hdrs):
>       raise HTTPError(req.full_url, code, msg, hdrs, fp)
E       urllib.error.HTTPError: HTTP Error 500: Internal Server Error

Also modifies a condition that just because the test can connect to a "check url" (google) doesn't necessarily mean the test can connect to the target server.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Jan 30, 2022
jbrockmendel
jbrockmendel approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added this to the 1.5 milestone Jan 30, 2022
@jreback jreback modified the milestones: 1.5, 1.4.1 Jan 30, 2022
@jreback jreback merged commit 4451392 into pandas-dev:main Jan 30, 2022
@jreback
Copy link
Contributor

jreback commented Jan 30, 2022

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 30, 2022
@mroeschke @meeseeksmachine
Backport PR pandas-dev#45723: TST: Allow tm.network to catch urllib.e…
d298ff5 
…rror.URLError
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 30, 2022
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 30, 2022

Something went wrong ... Please have a look at my logs.

@mroeschke mroeschke deleted the ref/tmnetwork branch January 31, 2022 01:59
jreback pushed a commit that referenced this pull request Jan 31, 2022
@meeseeksmachine @mroeschke
Backport PR #45723: TST: Allow tm.network to catch urllib.error.URLEr…
afe473e 
…ror (#45726)

Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@mroeschke @phofl
TST: Allow tm.network to catch urllib.error.URLError (pandas-dev#45723)
f3b7d1b
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
TST: Allow tm.network to catch urllib.error.URLError (pandas-dev#45723)
6f57362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees

No one assigned

Labels

IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mroeschke @jreback @jbrockmendel