Skip to content

REF: avoid ravel/reshape in astype_nansafe, ndarray_to_mgr #45817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2022
Merged

REF: avoid ravel/reshape in astype_nansafe, ndarray_to_mgr #45817

merged 4 commits into from
Feb 9, 2022

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 4, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jreback
Copy link
Contributor

jreback commented Feb 4, 2022

pandas/core/internals/blocks.py:1142: error: Argument 1 to "np_can_hold_element" has incompatible type "Union[dtype[Any], ExtensionDtype]"; expected "dtype[Any]" [arg-type]

i think this is on main right?

@jreback jreback added the Refactor Internal refactoring of code label Feb 4, 2022
@jreback jreback added this to the 1.5 milestone Feb 4, 2022
@jreback jreback added the Internals Related to non-user accessible pandas implementation label Feb 4, 2022
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Feb 4, 2022

i think this is on main right?

correct. #45796 includes a fix

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Feb 4, 2022

asv failure may be real, need to look into it

@jreback jreback merged commit 1699197 into pandas-dev:main Feb 9, 2022
@jbrockmendel jbrockmendel deleted the perf-ravels-core branch February 9, 2022 02:20
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jbrockmendel @phofl
REF: avoid ravel/reshape in astype_nansafe, ndarray_to_mgr (pandas-de…
b93bb00 
…v#45817)
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
REF: avoid ravel/reshape in astype_nansafe, ndarray_to_mgr (pandas-de…
771594a 
…v#45817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback