Skip to content

BUG: DataFrame[dt64].where downcasting #45837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 9 commits into from
Feb 11, 2022
Merged

BUG: DataFrame[dt64].where downcasting #45837

mroeschke merged 9 commits into from
Feb 11, 2022

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 5, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Feb 6, 2022
View reviewed changes
mroeschke
mroeschke reviewed Feb 6, 2022
View reviewed changes
@mroeschke mroeschke added this to the 1.5 milestone Feb 6, 2022
@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 6, 2022
@jreback
Copy link
Contributor

jreback commented Feb 9, 2022

hmm this didn't seem to run all of the checks. can you rebase

@jreback
Copy link
Contributor

jreback commented Feb 11, 2022

can you rebase

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Feb 11, 2022

rebased + greenish

@mroeschke mroeschke merged commit c1a492c into pandas-dev:main Feb 11, 2022
@mroeschke
Copy link
Member

mroeschke commented Feb 11, 2022

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-putmask-dta-split branch February 11, 2022 20:11
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jbrockmendel @phofl
BUG: DataFrame[dt64].where downcasting (pandas-dev#45837)
8a0e9a5 
* BUG: DataFrame[dt64].where downcasting

* whatsnew

* GH ref

* punt on dt64

* mypy fixup
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
BUG: DataFrame[dt64].where downcasting (pandas-dev#45837)
7c35cdf 
* BUG: DataFrame[dt64].where downcasting

* whatsnew

* GH ref

* punt on dt64

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jreback @mroeschke