TYP: Update type results for Groupby.count() and Groupby.size() #45904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
approved these changes
Feb 9, 2022
Member
twoertwein
left a comment
twoertwein
left a comment
There was a problem hiding this comment.
Looks good to me from a typing perspective.
jbrockmendel
reviewed
Feb 9, 2022
Member
This code sample raises |
Contributor
Author
I fixed it. Edited above. @simonjayhawkins @jbrockmendel just did a newer commit that takes advantage of the generic aspect of the |
Member
running code sample through interpreter gives... |
simonjayhawkins
approved these changes
Feb 10, 2022
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @Dr-Irv lgtm can you update the PR title to be more descriptive TYP: ...
Dr-Irv
changed the title
Contributor
Author
|
For the record, here is what I used for testing: import pandas as pd
from typing import TYPE_CHECKING
if not TYPE_CHECKING:
def reveal_type(*args, **kwargs):
pass
ind = pd.MultiIndex.from_product([["a", "b"], ["x", "y"]], names=["ab", "xy"])
df = pd.DataFrame({"x": [1, 2, 3, 4], "y": [4, 5, 6, 7]})
s = pd.Series([1, 2, 3, 4], index=ind)
cnt_df = df.groupby("x").count()
print(type(cnt_df))
cnt_df_s = df.groupby("x").y.count()
print(type(cnt_df_s))
# siz_df = df.groupby("x").size()
# print(type(siz_df))
app_df = df.groupby("x").apply(sum)
print(type(app_df))
cnt_df_a = df.groupby("x", as_index=False).count()
print(type(cnt_df_a))
cnt_df_s_a = df.groupby("x", as_index=False).y.count()
print(type(cnt_df_s_a))
# siz_df_a = df.groupby("x", as_index=False).size()
# print(type(siz_df_a))
app_df_a = df.groupby("x", as_index=False).apply(sum)
print(type(app_df_a))
cnt_s = s.groupby("ab").count()
print(type(cnt_s))
# siz_s = s.groupby("xy").size()
# print(type(siz_s))
app_s = s.groupby("xy").apply(sum)
print(type(app_s))
reveal_type(cnt_df)
reveal_type(cnt_df_s)
# reveal_type(siz_df)
reveal_type(app_df)
reveal_type(cnt_df_a)
reveal_type(cnt_df_s_a)
# reveal_type(siz_df_a)
reveal_type(app_df_a)
reveal_type(cnt_s)
# reveal_type(siz_s)
reveal_type(app_s)I took out the
The two |
Contributor
|
@Dr-Irv status here |
Contributor
Author
|
@jreback all green now - merged with latest main |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.N/A
Here's a test using
mypythat reveals the issue.Before this PR, the result of
mypyon thereveal_typelines is:After this PR, the result is:
This will be needed as we work on the general typing issues.