PERF: join empty frame #46015
Merged
PERF: join empty frame #46015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Performance
jreback
requested changes
Feb 16, 2022
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
do we have sufficient asv's to cover this?
pandas/core/indexes/base.py
Outdated
| if level is not None and (self._is_multi or other._is_multi): | ||
| return self._join_level(other, level, how=how) | ||
|
|
||
| if len(other) == 0 and how in ("left", "outer"): |
Contributor
There was a problem hiding this comment.
can you make a if len(other) and if len(self) clause then sub if's here for the cases
Member
Author
Added an asv to cover this. |
Member
Author
|
@jreback - greenish, errors look unrelated |
Member
|
Could you merge in main one more time? (failures look unrelated but good to be sure) |
Member
Author
|
@mroeschke - merged main. greenish again, let me know if you think the error is related |
mroeschke
approved these changes
Feb 22, 2022
Member
|
Thanks @lukemanley. The failure was unrelated |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* faster joins when left and/or right is empty * whatsnew * cleanup * add asv for joining with empty frame * asv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Similar to #45838, but for
DataFrame.join.DataFrame.joinalready had a fast path for joining with an empty frame but it only covered a limited set of cases. This PR makes the fast path a bit faster and covers additional cases.