Skip to content

Conversation

@Mariam-ke
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • Worked on during pyladies london sprint, cleaned up code and added SS01

@MarcoGorelli MarcoGorelli self-requested a review March 25, 2022 11:58
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - CI error is unrelated, merging as the relevant check (validate docstrings) still passes

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 25, 2022
@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Mar 25, 2022
@MarcoGorelli MarcoGorelli merged commit a5bc868 into pandas-dev:main Mar 25, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* Cleaned up codes in validate_docstrings

* Remove comma

* Added SS01

* noop (trying to start CI)

Co-authored-by: Mariam-ke <mariam.haji01@gmail.com>
Co-authored-by: Marco Gorelli <marcogorelli@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants