BUG: SeriesGroupBy apply wrong name #46623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma3da
force-pushed
the
GH46369_seriesgroupby_apply_wrong_name
branch
from
da9d644 to
afaa1c4
Compare
ma3da
changed the title
rhshadrach
requested changes
Apr 5, 2022
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Thanks for the PR; looks really good. One question.
jreback
requested changes
Apr 5, 2022
pandas/tests/groupby/test_apply.py
Outdated
| tm.assert_frame_equal(result, expected) | ||
|
|
||
|
|
||
| def test_result_name_when_one_group(): |
Contributor
There was a problem hiding this comment.
can you parameterize this tests instead of looping
pandas/tests/groupby/test_apply.py
Outdated
| result = ser.groupby(["a", "a"]).apply(lambda x: x).name | ||
| expected = name | ||
|
|
||
| assert result == expected |
Contributor
There was a problem hiding this comment.
can you tm.assert_series_equal and fully construct the expected series
ma3da
force-pushed
the
GH46369_seriesgroupby_apply_wrong_name
branch
from
afaa1c4 to
370d109
Compare
ma3da
force-pushed
the
GH46369_seriesgroupby_apply_wrong_name
branch
from
370d109 to
7d2198d
Compare
Member
|
@ma3da - can you merge main. |
…by_apply_wrong_name
mroeschke
approved these changes
Apr 16, 2022
Member
|
Failure is unrelated. Will need an approval from @jreback to move forward |
jreback
reviewed
Apr 16, 2022
pandas/core/groupby/generic.py
Outdated
| not_indexed_same=not_indexed_same, | ||
| override_group_keys=override_group_keys, | ||
| ) | ||
| result.name = self.obj.name # GH #46369 |
Contributor
There was a problem hiding this comment.
the issue comment is not necessary
jreback
approved these changes
Apr 18, 2022
Contributor
|
looks good can merge on green |
Member
|
Thanks @ma3da! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.