TST: Added test for bug Reindexing pd.Float64Dtype() series gives runtime warnings when passed to np.log #47087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
mroeschke
reviewed
Jun 3, 2022
| def test_reindexing_values(): | ||
| # GH 47055 | ||
| s = Series([1.0, NA], dtype=Float64Dtype()) | ||
| s_reindex = s.reindex(range(3)) |
Member
There was a problem hiding this comment.
- Could you move this test to
pandas/tests/series/methods/test_reindex.py? - Could you mention in the test name that it involves Float64 with NA?
- Could you also test that a warning isnt raised like
tm.assert_produces_warning(None):
result = np.log(s_reindex)
expected = ...
mroeschke
approved these changes
Jun 8, 2022
Member
|
Thanks @MiloniAtal |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…time warnings when passed to np.log (pandas-dev#47087) * TST: For issue GH 47055 * Changes according to pre-commit * Made changes according to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.Float64Dtype()series gives runtime warnings when passed tonp.log#47055doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.