DEPR: enforce deprecation on floats with unit=M or Y #48671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Frequency
mroeschke
reviewed
Oct 12, 2022
doc/source/whatsnew/v1.6.0.rst
Outdated
|
|
||
| Other API changes | ||
| ^^^^^^^^^^^^^^^^^ | ||
| - Disallow passing non-round floats to :class:`Timestamp` with ``unit="M"`` or ``unit="Y"`` (:issue:`47266`) |
Member
There was a problem hiding this comment.
Could you start a new section in the whatsnew for these like we did in 1.0? https://pandas.pydata.org/docs/whatsnew/v1.0.0.html#removal-of-prior-version-deprecations-changes
Member
Author
There was a problem hiding this comment.
after this is merged ill update the other deprecation-enforcing PRs to move the notes to the appropriate section
Member
Author
|
@phofl gentle ping, getting this in will allow us to move the whatsnew notes over to the new section and start getting those in |
phofl
approved these changes
Oct 19, 2022
Member
|
thx @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately just found that we missed the analogous behavior in to_datetime with non-scalars. That'll go in the just-do-in-2.0 pile.
Whatsnew is in 1.6 on the assumption it will be changed to 2.0.