Skip to content

Replace pylint message types with explicit message names #49160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcoGorelli merged 3 commits into from
Oct 19, 2022
Merged

Replace pylint message types with explicit message names #49160

MarcoGorelli merged 3 commits into from
Oct 19, 2022

Conversation

@Leviob
Copy link
Contributor

@Leviob Leviob commented Oct 17, 2022

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 17, 2022
@Leviob
Copy link
Contributor Author

Leviob commented Oct 18, 2022

For some reason my local pylint wasn't catching the warning at pandas/_libs/tslibs/__init__.py:38:0: W0406: Module import itself (import-self).

MarcoGorelli
MarcoGorelli approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Leviob

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Oct 19, 2022
@MarcoGorelli MarcoGorelli merged commit b94f1a1 into pandas-dev:main Oct 19, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@Leviob @noatamir
Replace pylint message types with explicit message names (pandas-dev#…
9c25a1a 
…49160)

* Replace pylint message types with explicit message names

* Add import-self to disabled pylint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Leviob @MarcoGorelli @mroeschke