Skip to content

Conversation

@uzzell
Copy link
Contributor

@uzzell uzzell commented Nov 25, 2022

Associated with #48855. Enables the Pylint type "R" warning unnecessary-list-index-lookup. Also updates the list of intentionally disabled checks.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this

could you please:

  • run the pre-commit checks (see contributing guide for how)
  • fetch upstream, and rebase onto it, looks like you have some irrelevant changes in here

@uzzell
Copy link
Contributor Author

uzzell commented Nov 28, 2022

@MarcoGorelli , are you talking about the changes to pyproject.toml? I took the liberty of updating the list of intentionally disabled warnings: wrong-import-order appeared twice in the list, while broad-except and overridden-final-method were in the list at the top of #48855 but not in the section for intentionally disabled warnings in pyproject.toml.

If you'd like, I can change them back.

@MarcoGorelli
Copy link
Member

ah, that's fine then, thanks for explaining!

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Nov 28, 2022
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 28, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @uzzell

@MarcoGorelli MarcoGorelli merged commit 56f3aaa into pandas-dev:main Nov 28, 2022
@uzzell uzzell deleted the enable-unnecessary-list-index-lookup branch November 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants